botpress / studio

The studio is the main interface you'll use to build and edit your chatbot.
https://botpress.com/docs/quickstart#conversation-studio
36 stars 38 forks source link

chore(deps): upgrade pkg version to sign binary #296

Closed ptrckbp closed 2 years ago

ptrckbp commented 2 years ago

This issue https://github.com/vercel/pkg/commit/0b55f9adba1f52d2aed171ca902d44fffa114af0 is preventing me from including the binary inside the electron app.

I tried packaging, and placing the studio binary within the master branch of botpress/botpress and it works flawlessly, but that's just one environment (Intel Macos). Please let me know if you need me to test this somehow.

allardy commented 2 years ago

Updating pkg means that we also upgrade to a new node version, which also means that there's a bunch of tests that we must do to ensure everything is stable, and we also need to update the version on the main repository at the same time.

And we need to test all binaries (windows, linux, mac)

samuelmasse commented 2 years ago

@ptrckbp Closing for inactivity. Feel free to re-open