botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
68 stars 83 forks source link

Oneflow routes through load balancer #1063

Closed BPMJoannette closed 3 years ago

BPMJoannette commented 3 years ago

In the oneflow designer, flows are saved under topics in a folder structure. Only one route is designed for them : api/v1/bots/{botId}/flow/

Example of a request made when saving a flow : /api/v1/bots/ndu10/flow/Main-topic%2FMain-flow.flow.json

Since the flows are in a folder structure, the slash is escaped here (%2F). This may cause trouble with some load balancers that will resolve this %2F to /

Cannot POST /api/v1/bots/ndu10/flow/Main-topic/Main-flow.flow.json

Steps to reproduce the behaviour:

  1. You need Botpress fronted by a load balancer such as Apache
  2. In the oneflow design, move any node
  3. See error

Expected behaviour: Route should be created programmatically so the call is standardized, without escaping characters.

See ticket # 1167 for more details.

Botpress Version 12.10.1

EFF commented 3 years ago

Thank you for reporting this, this is indeed quite critical once we release oneflow