botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
83 stars 90 forks source link

Production Checklist: Enable Sticky Sessions indicator #1122

Open BPMJoannette opened 4 years ago

BPMJoannette commented 4 years ago

Describe the bug This item does not help figure out if sticky is enabled or not, since it is not using socket.io, but the API ping route which may not be returning an accurate result.

On a server with sticky enabled, we can sometimes see this warning: image

To Reproduce Steps to reproduce the behavior:

  1. Deploy Botpress with multiple nodes and sticky enabled
  2. Verify the Production Checklist

Expected behavior Sticky should be determined more clearly.

Environment :

allardy commented 4 years ago

The check to determine if sticky session is enabled or not is very basic and i'm not sure how to implement it to detect every scenarios. Which ones are correctly detected right now, and which one are not ?

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

davidvitora commented 3 years ago

Reopening the issue since it stills pertinent, this warning probably needs to be removed or fixed, depending on the solution.

EFF commented 3 years ago

We can't determine this accurately, let's simply not display the configured status and display as bullet instead