botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
68 stars 83 forks source link

[BUG] Converse API - Concurrent Messages for the same User ID #1408

Closed hacheybj closed 2 years ago

hacheybj commented 2 years ago

Describe the bug Botpress will crash when multiple requests are made concurrently through the converse API for a unique userid.

To Reproduce Send 5 requests at the same time to the converse API with the same userId.

Expected behavior Some kind of Qing mechanism, or clear error message that closes the connection rather than crash botpress.

Screenshots n/a

Environment (please complete the following information): 12.23.0

Additional context

08/02/2021 16:17:20.347 Launcher Unhandled Rejection [Error, Request timed out.]
STACK TRACE
Error: Request timed out.
    at Timeout._onTimeout (/snapshot/build-linux/out/bp/core/converse/converse-service.js)
    at listOnTimeout (internal/timers.js:549:17)
    at processTimers (internal/timers.js:492:7)
08/02/2021 16:17:20.521 Cluster Exceeded the maximum number of automatic server reboot (3). Set the "BP_MAX_SERVER_REBOOT" environment variable to change that
startBotServer.sh: bot server Exiting
samuelmasse commented 2 years ago

Same issue as botpress/v12#1439. Was fixed in 12.24.0