botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
76 stars 87 forks source link

[BUG] Remove the Vonage Error from the studio #1441

Closed poojapatil12 closed 2 years ago

poojapatil12 commented 3 years ago

Describe the bug

  1. Build your flow, select node select the type of content. Select video

image

  1. Add a new video
  2. A warning appears: Video content-type is currently only supported by channel-vonage

image

Environment (please complete the following information):

laurentlp commented 3 years ago

@poojapatil12 It's only a warning message and any particular reason we should remove it?

I agree that we could add channel-web alongside channel-vonage as the two channels that support this content-type, but personally, I would still keep it.

poojapatil12 commented 3 years ago

Hey @laurentlp ,

  1. It leads to a poor user experience.
  2. If the channel Vonage is not enabled, showing that the Video is supported leads to confusion, since the bot builder selects it only to find out it's not
laurentlp commented 3 years ago
  1. If the channel Vonage is not enabled, showing that the Video is supported leads to confusion, since the bot builder selects it only to find out it's not

Wouldn't removing the warning lead to more confusion as only channel-vonage and channel-web support this content-type? Same goes for Audio, File, and Location content-types.

I would personally find it annoying if I were to use a content-type that simply displays nothing when using one of the other channels!

Furthermore, since v12.24.0 there is no longer a notion of enabling and disabling a channel module. All channel-related code has been moved to the botpress/messaging repository and by default, they are all available but unconfigured. You simply need to add the channel configuration to your bot.config.json file in order to 'enable' it.

Nadine15 commented 2 years ago

Adjust warning message to "Please note that video content-type is only supported in channel-web and channel-vonage"