search

botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
69 stars 83 forks source link

[BUG] Editing skill deletes added transitions #1455

Open ptrckbp opened 2 years ago

ptrckbp commented 2 years ago

Describe the bug Once you have a skill set up, if you click edit skill, the existing non-skill related transitions disappear.

To Reproduce Steps to reproduce the behavior:

  1. Go to flow
  2. Create a simple choice skill
  3. Add a transition to it
  4. Click "edit skill"
  5. Immediately click "save", no need to actually change anything
  6. the transition will disappear without warning

Expected behavior The transition should not disappear, or there should be a confirm dialog. Or, If i'm doing something wrong and the transitions shouldn't be there, then there shouldn't be a plus button to add a transition.

Environment (please complete the following information):

Additional context I'm also not sure if this universal across skills, but this happens for choices and slot filling skills.

Reason to change : this is the kind of issue where something the user did disappears without warning or explanation. It can lead to a bit of frustration.

tomkcey commented 2 years ago

On the latest master branch, I cannot reproduce the issue.

Here's a video to showcase.

ptrckbp commented 2 years ago

Had a call with tomkcey to clarify things.

The reason I wanted to do this was to have suggestions. I was using a Choice skill to achieve that, as AFAIK it is the only way to include buttons within Botpress without custom modules.

An example would be :

"What would you like to do today?"

[suggestions START] "shop" "lookup my order" [suggestions end]

[text input]

So the user could click shop and lookup my order, or type whatever he wants.

We figured out a way to do this by using onFailure and setting max_retries to 0, then catching intent in the next node.

This means, at least as far as this use case is concerned, we could freely remove the ability to be able to add / remove transitions in Choice Skills.

jonathborg commented 2 years ago

Same problem. When I add a "Intent is" transition. Edit the skill and then save, it's override all transitions. Any updates on this?

EFF commented 2 years ago

I really cannot reproduce I added pretty much every thing you asked for

Anything else ?

https://user-images.githubusercontent.com/955524/146022104-d0ec933b-e246-4943-863c-6cb57c4e9b06.mp4