search

botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
68 stars 83 forks source link

[BUG] Language change is inconsistent #1574

Open davidvitora opened 2 years ago

davidvitora commented 2 years ago

Describe the bug Inconsistency during language change, if you have a bot with only one language, if you change it, you can't train your NLU until restarting the Botpress Server.

To Reproduce Steps to reproduce the behavior:

  1. Create a Bot.
  2. Change language to any other (keep it as a single language bot).
  3. You can't see the 'Train Chatbot' button anymore, it will only be fixed after restarting the server.

Expected behavior The Train Chatbot button to appear

Environment (please complete the following information):

Additional context This seems is to be related to the fact that module hooks (OnBotMount/OnBotUnmount) are not triggered in the current version.

image

Unmount/mount is a process that is done to update the bot configuration, but right now, there is code duplication in both core and studio repositories, creating inconsistency in the Behavior. So right now the module hooks are only being triggered during Server initialization.

Helle1 commented 1 year ago

I can confirm this behavior. A restart is necessary to "activate" the learning in other languages than English.