Describe the bug
Messages are never sent to users matching the filters.
To Reproduce
Steps to reproduce the behavior:
Enable the broadcast module.
Open a conversation using the emulator.
Go to the broadcast module, create a new one, and add channel == 'web' as a filter. Remember to click the 'Add' button to actually add the filter.
Expected behavior
The message is sent to the matching users, which are those with channel == web, so at least the emulator conversation should receive it.
Instead, no message is sent.
Environment (please complete the following information):
Botpress Version: 12.30.8
Additional context
The main problem is that in daemon.ts, line 38, Botpress returns this typeof v !== 'undefined' && v !== null instead of the value of v, the variable in which the result of the matching is stored. If everything works fine v won't be undefined nor null, thus returning "true", which is the final value of drop of the dropPromise, dropping that message.
From what I've read I know that the Broadcast module was never ready, but I think it would be nice to have at least this fixed - I'll send a pull request in a couple of minutes.
Describe the bug Messages are never sent to users matching the filters.
To Reproduce Steps to reproduce the behavior:
channel == 'web'as a filter. Remember to click the 'Add' button to actually add the filter.Expected behavior The message is sent to the matching users, which are those with channel == web, so at least the emulator conversation should receive it.
Instead, no message is sent.
Environment (please complete the following information):
Additional context The main problem is that in
daemon.ts, line 38, Botpress returns thistypeof v !== 'undefined' && v !== nullinstead of the value of v, the variable in which the result of the matching is stored. If everything works fine v won't be undefined nor null, thus returning "true", which is the final value ofdropof thedropPromise, dropping that message.From what I've read I know that the Broadcast module was never ready, but I think it would be nice to have at least this fixed - I'll send a pull request in a couple of minutes.