botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
76 stars 86 forks source link

Content type attributes with falsey values lead to a value of undefined in event payload #1834

Open ibarreto opened 3 months ago

ibarreto commented 3 months ago

Describe the bug There's a bug here where if the value of a property is falsey (false, '', etc.) then separatorExtraction(prop) evaluates to falsey, which would be the case for when we have something like "property$en": false, then the code will evaluate nestedDictExtraction(prop), and that nested dictionary might not be defined in the content type and thus return undefined, so we end up with a property: undefined in the payload.

To Reproduce Have a content element where the type is boolean and is set to false, where it uses the property$language separator.

Expected behavior Instead of getting undefined in the payload, we should have false (or the relevant falsey value)

Environment (please complete the following information):

Additional context Add any other context about the problem here.