botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
69 stars 83 forks source link

[Bug] Content Manager – Minor UI glitches #213

Closed emirotin closed 6 years ago

emirotin commented 6 years ago

Some of them may already be fixed, need validation.

dmytropanontko commented 6 years ago

@emirotin Hi) Is it actual issue? If yes please give me more details, ty)))

emirotin commented 6 years ago

Please test the first two (unchecked) items. If you can reproduce them — welcome to fix :) I've added a bit of details to the first one, the second looks sufficiently explained to me, please ask any specific questions you have.

dmytropanontko commented 6 years ago

@emirotin For second point it's normal behavior 2. When a dialog closes, focus returns to the element that invoked the dialog unless either: ... you can find this text here https://www.w3.org/TR/wai-aria-practices-1.1/#dialog_modal in NOTE:

dmytropanontko commented 6 years ago

It's for first one. Did you talked about this image

emirotin commented 6 years ago

The 2nd point should already be addressed by your earlier change which auto-picks the newly created content item. When you cancel the dialog this behavior is normal indeed.

dmytropanontko commented 6 years ago

@emirotin Can you provide more details for 1 because I'm not shure that I understand where is it? And I don't see which flow must be. Thanks

Is it here: image

emirotin commented 6 years ago

I think we can close this until we hear these complaints from the users again. I think your change to "pick on create" might have addressed the first point too.