botpress / v12

Botpress OSS – v12
https://v12.botpress.com
GNU Affero General Public License v3.0
68 stars 83 forks source link

Transition Links get reset when some change is made in the Call API Skill in Botpress #857

Closed kevit-parth-mansata closed 4 years ago

kevit-parth-mansata commented 4 years ago

Describe the bug I created a flow in the latest version v12.2.2 of Botpress in the editor studio. Once an API skill is created and transition links with custom condition from that API are made to other node/subflow, after re-editing that API skill and saving, all the transition links get reset.
To Reproduce Steps to reproduce the behavior:

  1. Create a Call API Skill
  2. Add more than one custom condition for transition (ex. if user.isValidated === true)
  3. Join links to other nodes or subflows
  4. Edit the API Call skill(let say edit the URL of API)
  5. Save the Skill, and the transitions would be showing missing links.

Expected behavior A clear and concise description of what you expected to happen.

Environment:

allardy commented 4 years ago

@parth-mansata This is a known bug that's been there for a long time, but it will be fixed in the next release (12-2-3)

kevit-parth-mansata commented 4 years ago

Waiting for the next release then! @allardy

allardy commented 4 years ago

@parth-mansata Sorry, I might have read your issue a little bit too quick. What we did fix in v12.2.3 is when you save a skill, then edit transitions manually (to change the flow, for example), when saving transition, the label was removed. When editing the skill afterwards and saving, it was removing the transitions, and you had to make them again.

The issue you have is not really an issue. When you save a skill, it will always make sure that the required transitions are available. If its "official" transitions are missing, it will create them. If there are "intruder" transitions, it will delete them.

What you need is to create an intermediate node, which will handle your context-specific conditions, example:

image

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.