channel-slack RTMClient does not start

[null-directory]

Describe the bug

Slack is deprecating RTM bot permissions. This link currently works but won't past 2020-02-21 Slack: Create new legacy RTM app

On a banner at the top of the newly created app page:

Slack has improved how we handle permissions for apps, so you can now request only the specific scopes your app needs. We recommend updating your app’s scopes. Beginning February 21, all new app submissions to the App Directory must use granular permissions. Read our blog post.

When configuring Slack integration with granular permissions (container (10).log) , container startup fails with the following error (also attached). Digging in, this seems to be related to how Slack is setting up App integrations, where new apps by default do not use the RTM permissions.

no port specified, defaulting to port 8000 
Listening on http://0.0.0.0:8000 
  ======================================== 

                                     Version 12.5.0              
                                 OS linux ubuntu_18_04          
                        ======================================== 
  App Data Dir: "/root/botpress" 
  Using  modules 
                         analytics 
                         basic-skills 
                         builtin 
                         channel-slack 
                         channel-web 
                         code-editor 
                         examples 
                         extensions 
                         nlu 
                         qna 
                         testing 
                        ⊝ channel-messenger  
                        ⊝ channel-smooch  
                        ⊝ channel-teams  
                        ⊝ channel-telegram  
                        ⊝ hitl  
                        ⊝ misunderstood  
                        ⊝ nlu-extras  
                        ⊝ nlu-testing  
                        ⊝ uipath  
  Loaded 11 modules 
  Loaded 7 content types 
  [greeter] Interactive Endpoint URL: https://botpress.null.directory/api/v1/bots/greeter/mod/channel-slack/bots/greeter/callback 
[INFO]  RTMClient:1 unable to RTM start: An API error occurred: not_allowed_token_type 

To Reproduce Steps to reproduce the behavior:

1. Create example greeter bot.
2. Activate channel-slack module
3. Configure channel-slack.json for the bot, using tutorial in the Botpress Slack integration
4. See error

Expected behavior Botpress starts and greeter bot responds in Slack.

Screenshots

From the container orchestration logs:

Warning from the Slack admin page:

Counterpoint: creating a legacy bot to show difference:

After configuring as tutorial suggests:

And here's the bot on my Slack channel:

Environment (please complete the following information):

• OS: Docker image botpress/server:v12_5_0
• Browser: Chrome
• Version: 12.5.0
• NodeJS: ----

[luisbattle]

Hi Any idea about the fix? thanks

[null-directory]

Looking at the Event and RTM API, I'm guessing we could maybe port directly from RTM to Events. I'm willing to dig into it and learn enough to make a patch, I just won't be able to touch it for a couple weeks or so.

[spg]

I confirm the issue is happening. Thanks for reporting. You can find more information about the upstream issue here: https://github.com/slackapi/node-slack-sdk/issues/921

The solution would be to support both the RTM api (for legacy Slack apps) and the Events (for Bot Granular Permissions apps). Removing support for the RTM api from Botpress would introduce breaking changes to existing Botpress installations.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[EFF]

Fixed