botr99 / pe

0 stars 0 forks source link

Phone number can start with 0 #16

Open botr99 opened 3 years ago

botr99 commented 3 years ago

Steps to replicate:

  1. add n/A e/aaa.b@aa-bbd a/Newgate Prison p/00000001

Expected: Fails as phone number is only 1 digit long (1, after removing all preceding zeroes) since phone numbers cannot start with a 0.

Actual: Added to address book.

image.png

nus-pe-bot commented 3 years ago

Team's Response

Our phone number format is meant to be flexible, to support arbitrary phone numbers across the world.

Have a look at this excerpt from this page, where having a phone number that starts with 0 is helpful.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]