bots-edi / bots

Bots EDI Translator
GNU General Public License v3.0
138 stars 83 forks source link

review setup*.py files in root-directory #24

Open woutervh opened 7 years ago

woutervh commented 7 years ago

I made setup.py the other ones seems very old-style.

And since we can now use "pip install", it does not make sense to build windows-executables IMHO we no longer need the other setup_*.py files

djfurman commented 7 years ago

I agree that those are no longer necessary.

Using your revised setup.py script; can the declared dependencies be installed directly (by using something other than pip install bots or python setup.py install)? Or would it be helpful to add a requirements.txt file?

Admittedly, I'm somewhat of a newbie when it comes to python deployment best practices.

dwoz commented 7 years ago

+1 on requirements.txt

sdwarwick commented 6 years ago

Any chance of testing against python 3.7? have moved almost everything we do to this release.