search

botsarefuture / mielenosoitukset_fi

Mielenosoitukset.fi is a website designed for Finland's demonstrations.
https://mielenosoitukset.fi
Apache License 2.0
1 stars 0 forks source link

Multilinguality #115

Open botsarefuture opened 1 week ago

botsarefuture commented 4 days ago

Now we use transifex for making the translations!

botsarefuture commented 3 days ago

@samimaat is this the proper way to handle aria-label, or should we wrap it in {{ _('Etsi käyttäjiä') }} first?

Basically:

https://github.com/botsarefuture/mielenosoitukset_fi/blob/1bb68f537930cac4bf934744f229695a7dca9af3/templates/admin/user/list.html#L92-L93

samimaat commented 2 days ago

If I understood correctly that you simply want to translate the input field to English, then you should translate the <label> element's content and the placeholder attribute's content.

aria-label isn't needed when it's done this way. In its current implementation it mixes Finnish and English, which would be confusing either way.

Edit: Oh, sorry I didn't actually read what you asked. aria-label is text as is everything else, so it should be in the native language.

It is redundant here though, because the <label> already tells the user what the input field is. So aria-label attribute can be removed.

botsarefuture commented 2 days ago

Okay! Thank you!

I thought that as well, but just wanted to make sure.