bottledcode / swytch-framework

The Smart PHP Framework
https://framework.getswytch.com/
MIT License
20 stars 0 forks source link

clean up the router a bit #22

Closed withinboredom closed 1 year ago

withinboredom commented 1 year ago

Just clean up things a bit and address some phpstan warnings

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.04 :warning:

Comparison is base (91cd2c4) 58.71% compared to head (1f6a731) 58.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #22 +/- ## ============================================ - Coverage 58.71% 58.68% -0.04% Complexity 283 283 ============================================ Files 36 36 Lines 780 789 +9 ============================================ + Hits 458 463 +5 - Misses 322 326 +4 ``` | [Impacted Files](https://codecov.io/gh/bottledcode/swytch-framework/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bottledcode) | Coverage Δ | | |---|---|---| | [src/Router/MagicRouter.php](https://codecov.io/gh/bottledcode/swytch-framework/pull/22?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bottledcode#diff-c3JjL1JvdXRlci9NYWdpY1JvdXRlci5waHA=) | `72.07% <66.66%> (-1.46%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bottledcode). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bottledcode)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.