search

bottlepy / bottle

bottle.py is a fast and simple micro-framework for python web-applications.
http://bottlepy.org/
MIT License
8.44k stars 1.47k forks source link

Removing Python 2 support from 0.13 #1193

Open defnull opened 4 years ago

defnull commented 4 years ago

This is the integration branch for python 2 removal. Please submit pull requests against this branch and discuss the entire process here.

defnull commented 4 years ago

Since Bottle-0.12 will be the last release supporting Python 2 (2.5+ actually) and very old versions of Python 3 (3.2+), it will become an LTS release and will be maintained (security patches only) for a bit longer than usual. This allows us to drop support for old python versions without hurting existing users too much.

I'm thinking about skipping 0.13 and move forward to 0.14 in a single step to make it more clear that there are breaking changes this time. Spamming all 0.12/Py2 users with a deprecation warning is a bit too much I think. Some people can't update, even if they want to.

oz123 commented 4 years ago

@defnull this is very welcome. According to your own roadmap the aren't many blocking issues for 0.13. but it's been so long since the first map was written I'm not sure it's even relevant. It's a good sign for people to get a new release out. Please go ahead and do this ASAP.

oz123 commented 4 years ago

@defnull also, please remove the classification from setup.py https://github.com/bottlepy/bottle/blob/8561ffbc2ed2b16b4f7f90520d148e37e251d107/setup.py#L34.

You should also drop python 3.4. it's no longer maintained.

stigok commented 4 years ago

Also remember to remove unsupported targets from the root Makefile. Edit: Or maybe keeping those if the plan is to have 2.7 in an LTS state.

defnull commented 4 years ago

The release-0.12 branch has its own Makefile and test suite. We can remove any trace of 2.7 or 3.4 support from the master branch.

cclauss commented 3 years ago

It has been a year... Conflicts.

defnull commented 3 years ago

Yes, it probably wasn't the best idea to start with this before 2.7 is actually EOL and expect that there are no conflicts.

SergBobrovsky commented 3 years ago

All declarations like 

class A(object):

may be reduced to

class A:
cclauss commented 3 years ago

@SergBobrovsky That is an optional change but can be automated via tools like https://github.com/asottile/pyupgrade

SergBobrovsky commented 3 years ago

remove

from __future__ import print_function
cclauss commented 3 years ago

Also automated by pyupgrade. Give it a try to see the changes that it would make.

clavedeluna commented 2 years ago

Hey @defnull what's the status on this work? I'm happy to contribute but I saw your comment elsewhere stating you'd prefer this be done in smaller pieces?