search

bottlepy / bottle

bottle.py is a fast and simple micro-framework for python web-applications.
http://bottlepy.org/
MIT License
8.37k stars 1.46k forks source link

Fix build by dropping support for fapws3 server #1247

Closed braedon closed 3 years ago

braedon commented 3 years ago

Github actions currently hangs indefinitely while trying to install fapws3 on Python 2.7, breaking the build. (It just fails on 3.x due to a print statement in the setup.py.)

fapws3 only works with Python 2, which is no longer supported. The project appears to be unmaintained - the last commit was 3 years ago.

(Note: I spent quite a while trying to work out why installing it no longer works on Github actions, without any luck. This seemed like the next best course of action.)

defnull commented 3 years ago

Python 2.7 is still supported by bottle to some extend, but fapws3 should be dropped, yes. Could you make FapwsServer emit a helpful deprecation warning and add some info to the changelog, so people updating at least know what is going on? Changelog is not really up to date, but at least breaking changes should appear there.

defnull commented 3 years ago

I deprecated fapws3 and removed links from the docs. We can completely remove it in the future.