search

bottlepy / bottle

bottle.py is a fast and simple micro-framework for python web-applications.
http://bottlepy.org/
MIT License
8.37k stars 1.46k forks source link

Add tests for #602 bug #1248

Closed sirex closed 3 years ago

sirex commented 3 years ago

It looks that #602 is gone, but I'm not sure when exactly it was fixed.

I see that there is a suspicious change here:

environ['PATH_INFO'] = path.encode('latin1').decode('utf8', 'ignore')

Where original cause of the error was removed and replaced by 'ignore'.

Also fixed deprecation warnings, where:

@self.subapp.route('')

Does exactly same thing as this:

@self.subapp.route('/test/<test>')

Where '' is passed to route(), then makelist() utility assumes that nothing is passed and falls back to path autogeneration from callback function. Not sure if this is expected behaviour?

defnull commented 3 years ago

An empty path makes no sense (paths always start with /) so I'd call it undefined behaviour :)