search

bottlepy / bottle

bottle.py is a fast and simple micro-framework for python web-applications.
http://bottlepy.org/
MIT License
8.4k stars 1.46k forks source link

run_tests.yml: Add Python 3.9 to the testing #1252

Closed cclauss closed 3 years ago

defnull commented 3 years ago

Why did you remove the cherrypy<9 restriction? (And why did test pass without it? I thought that their API changed with 9+)

cclauss commented 3 years ago

I removed cherrypy<9 because cherrypy is on v18 and https://github.com/bottlepy/bottle/runs/1386872236#step:5:63 which was caused by Python 3.9 cleanup of obsolete clutter... https://bugs.python.org/issue37804

AssertionError: AttributeError: 'WorkerThread' object has no attribute 'isAlive'

defnull commented 3 years ago

Yes, but cherrypy >= 9 did not work with the server adapter because they out-sourced their WSGI implementation to a separate module (cheroot) and broke their API to use it from the cherrypy module. That's why we dropped support for cherrypy 9+ and users should move to cheroot instead.

defnull commented 3 years ago

I'm wondering why the tests pass with cherrypy 18 again.

defnull commented 3 years ago

I added newer python verions to test without the cherrypy change. Still think we should drop cherrypy in favour of cheroot. Thanks anyway!

cclauss commented 3 years ago

Look like you will have to modify the tests or drop ancient 🍒py or hold off on Py39... AttributeError: 'WorkerThread' object has no attribute 'isAlive'