search

bottlepy / bottle

bottle.py is a fast and simple micro-framework for python web-applications.
http://bottlepy.org/
MIT License
8.34k stars 1.46k forks source link

new server adapter #1254

Closed Ksengine closed 3 years ago

Ksengine commented 3 years ago

new server adapter for @Ksengine/Servelight This server is based on wsgiref source code. but with following updates.

so I added server adapter I had read -

according to #1253 Isuue

Ksengine commented 3 years ago

No reply for this pull?

defnull commented 3 years ago

No tests or docs, and it won't work I guess, since FixedHandler is not defined in that namespace. As mentioned in #1255, there are too many WSGI implementations to support them all. New server adapters should have a clear benefit over setting up the server manually, more than just convenience. Thanks anyway.

Ksengine commented 3 years ago

No tests or docs, and it won't work I guess, since FixedHandler is not defined in that namespace.

no need to define FixedHandler. all bugs were fixed from @Ksengine/Servelight

Ksengine commented 3 years ago

wsgiref adds PEP333 for python2 and PEP3333 for python3 @Ksengine/Servelight adds PEP3333 for any python version/implementation this pr adds only few lines to to bottle

Ksengine commented 3 years ago

I will make tests and docs

Ksengine commented 3 years ago

would you like to accept

defnull commented 3 years ago

A server adapter is not needed to use "Servelight" with bottle. As mentioned in #1255, there are too many WSGI implementations to support them all. New server adapters should have a clear benefit over setting up the server manually, more than just convenience.

Ksengine commented 3 years ago

It has multi-threading and multi-processing servers

defnull commented 3 years ago

I sense a communication problem here. Servelight may be great and have many benefits over wsgiref, but we are talking about adding a server adapter to bottle, not about how great Servelight is. You do not need a server adapter to use Servelight with bottle. It's actually harmful. A simple server adapter would hide most of the features Servelight offers. So why add it?

Ksengine commented 3 years ago

Its featured but not popular yet. bottle can use Its features.

defnull commented 3 years ago

Server adapters are not a suitable way to promote new projects, sorry.

Ksengine commented 3 years ago

Server adapters are not a suitable way to promote new projects, sorry.

can I add description about ServeLight to bottle docs

Ksengine commented 3 years ago

1256

Jwink3101 commented 3 years ago

can I add description about ServeLight to bottle doc

I am not in any position of power but I think this in a wikis may eventually be the appropriate answer if ServeLight gains in popularity.

But given its current status, my opinion is that it shouldn't be there! It's just too new without much popularity and, as you've said in your own replies, all it takes is two lines or so to use. So the right answer is to advertise in your repo how easy it is to use with Bottle.

If it ever gains a real following and has very clear advantages over what is there, then maybe it would make sense in a wiki-type page. But it doesn't need to go into the docs.

I am not an admin or anything on Bottle but at this point, you're more-or-less spamming the issues.

Just because you don't like the answer, it does not mean you should keep asking and posting. It is an inappropriate use of the Issues tracker and, at this point, counter productive.

Ksengine commented 3 years ago

all it takes is two lines or so to use

Hey, servelight is not a patch to wsgire Its forked from wsgiref and improved I had edited many lines to complete it.

2 lines for wsgiref means a patch

Ksengine commented 3 years ago

Servelight works without wsgiref

defnull commented 3 years ago

Read more carefully. We do not discuss Servelight here, but the proposed server adapter.

I do not know how to explain this more clearly: If a user wants to use Servelight with bottle, he or she can do that right now. No change needed. The documentation on how to use Servelight with a WSGI framework should be on the Servelight webpage, not here.