search

bottlepy / bottle

bottle.py is a fast and simple micro-framework for python web-applications.
http://bottlepy.org/
MIT License
8.39k stars 1.46k forks source link

refactot Route.all_plugins() #1306

Open SergBobrovsky opened 3 years ago

SergBobrovsky commented 3 years ago

My code accurately reproduces original functional, but is it correct? In original code unique collects plugin names to avoid repeats. If plugin has no name, this check not. So, noname plugin can repeats. Is it right logic?

oz123 commented 3 years ago

@SergBobrovsky you do a really cool job on those PRs. Keep up and take the critics as constructive criticism.