search

bottlerocket-os / bottlerocket-project-website

Source code and content for the bottlerocket website
https://bottlerocket.dev/
Apache License 2.0
9 stars 17 forks source link

fix(doc): ECS_CONTAINER_STOP_TIMEOUT #446

Closed remiflament closed 8 months ago

remiflament commented 8 months ago

Issue number:

None

Description of changes:

Fix the doc of ECS_CONTAINER_STOP_TIMEOUT

stockholmux commented 8 months ago

hey @remiflament - thanks for this - definitely a good catch that ECS_CONTAINER_STOP_TIMEOUT doesn't map to ECS_DISABLE_PRIVILEGED!

I'm unclear, however, that the value is supposed to be in seconds only.

It looks like Bottlerocket isn't doing any extra modification of this setting and the ECS agent's test use the s suffix on the value (e.g. 60s instead of just 60).

@arnaldo2792 you added this setting, could you clarify if the intended value should be raw seconds or with time units?

remiflament commented 8 months ago

Thanks for your reply, it's definitely the number and the suffix as my ECS deployment failed yesterday with just a number... let me fix that PR.

remiflament commented 8 months ago

Hello @stockholmux, I changed it to include the suffix. In the AWS documentation, the default timeout is 30 seconds. Let me know if it's ok for you. Have a nice day

stockholmux commented 8 months ago

@remiflament Thank you so much for this! I'll get it published in the next couple of days.

arnaldo2792 commented 8 months ago

@stockholmux , I just saw this, the configured value should include the units. Thanks @remiflament !