search

bottlerocket-os / bottlerocket-project-website

Source code and content for the bottlerocket website
https://bottlerocket.dev/
Apache License 2.0
9 stars 17 forks source link

fix: Nvidia driver versions script #492

Closed piyush-jena closed 3 weeks ago

piyush-jena commented 1 month ago

Description of changes: This change fixes scripts relevant to fetching nvidia driver versions for the website. After bifurcation of the monorepo to core-kit, bottlerocket and settings-sdk, the relevant driver versions no longer can be found in the original bottlerocket repo. It can be found in the core-kit repo which is now reflected here. Also, this script would no longer pick neuron drivers.

Terms of contribution:

By submitting this pull request, I confirm that my contribution is made under the terms of the licenses outlined in the LICENSE-SUMMARY file.

koooosh commented 1 month ago

Is there a reason why we have these in 2 commits? Can we just have it in one since they are related to the same fix: scripts: update nvidia-driver-versions to fetch from core-kit ?

piyush-jena commented 1 month ago

@koooosh I wanted to fix the scripts in 1 commit and do the manual correction in older versions in a separate commit.

piyush-jena commented 1 month ago

^ Resolved @larvacea 's comment and renamed commits to better explain the purpose of each.