search

bottlerocket-os / bottlerocket

An operating system designed for hosting containers
https://bottlerocket.dev
Other
8.64k stars 508 forks source link

Revert mounting static kmod as /sbin/modprobe #4026

Closed yeazelm closed 3 months ago

yeazelm commented 3 months ago

Description of changes: We found this change to be unsafe for alpine containers in our testing. Reverting this change for the time being until we can find a way to do this safely for all containers.

Testing done: Attempt to launch an image based upon alpine, the process dies with exit 254 when trying to run alpine images.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

larvacea commented 3 months ago

I believe the lint failure does not need to be fixed immediately.