bottlerocket-os / bottlerocket

An operating system designed for hosting containers
https://bottlerocket.dev
Other
8.78k stars 519 forks source link

apiclient: revert set/apply client error messages #4033

Closed sumukhballal closed 5 months ago

sumukhballal commented 5 months ago

Issue number:

Closes #4021

Description of changes:

@bcressey noticed that on system reboot on a Bottlerocket instance, the system failed to reboot due to a settings-committer error. This was because for default transactions (bottlerocket-launch), the changes need to be ignored by settings-committer via a Response Status from the APIServer. But, we had updated the Error response in #3987 to make our Client side messaging match what was present before. This change caused the dependents (in this case settings-committer) to change its behavior.

The fix here is to revert the client side messaging, so that consumers of the APIClient library will continue to work as is. We will have another PR focused on improving the Client side messaging to match what was there previously.

Testing done:

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.