search

bottlerocket-os / bottlerocket

An operating system designed for hosting containers
https://bottlerocket.dev
Other
8.64k stars 508 forks source link

sources: move settings-sdk to workspace dependencies #4099

Closed sam-berning closed 2 months ago

sam-berning commented 2 months ago

Issue number:

N/A

Description of changes:

Within the sources/ workspace, if a crate depends on one of the crates in bottlerocket-settings-sdk, we currently include a section with the full git URL, tag, and version in the crate's Cargo.toml. Because we can't have two versions of the same crate in a workspace, updating one of these Cargo.toml's (in order to test changes in a personal fork, or to bump the version, for example) requires updating all of the other crates that use that dependency.

Making the crates in bottlerocket-settings-sdk workspace dependencies allows us to update to a different version of bottlerocket-settings-sdk by only changing one file.

Testing done:

cargo build in sources/

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

sam-berning commented 2 months ago

Yeah, I think I like that too! I'll update it.

sam-berning commented 2 months ago

^ moved settings plugins deps back to their own section and updated formatting to dependency.workspace = true