search

bottlerocket-os / bottlerocket

An operating system designed for hosting containers
https://bottlerocket.dev
Other
8.64k stars 508 forks source link

`cargo make ami` does not use environment variable `PUBLISH_AMI_NAME` #4101

Open sumukhballal opened 2 months ago

sumukhballal commented 2 months ago

Platform I'm building on:

AWS aarch64

What I expected to happen:

While creating and registering an AMI, I ran the make AMI command.

cargo make ami -e PUBLISH_AMI_NAME=testing_k8s

I expected it to register the AMI, with the name: testing_k8s. This is also specified here: https://github.com/bottlerocket-os/bottlerocket/blob/develop/PUBLISHING-AWS.md?plain=1#L28

What actually happened:

But it looks like it ignored the provided variable PUBLISH_AMI_NAME and instead registered the AMI with name bottlerocket-aws-k8s-1.24-aarch64-v1.21.0-REDACTED-dirty. It should not ignore this variable and it should register the AMI with the provided variable name.

How to reproduce the problem:

Run the default build of bottlerocket

cargo make

and then create/register an AMI.

cargo make ami -e PUBLISH_AMI_NAME=testing_k8s