bottlerocket-os / twoliter

A build tool for customizing Bottlerocket
Other
24 stars 25 forks source link

twoliter: allow partial lockfile validation in some scenarios #361

Closed cbgbt closed 2 months ago

cbgbt commented 2 months ago

Description of changes:

    twoliter: allow partial lockfile validation in some scenarios

    In some CI scenarios, it's useful to drop previously-built variant
    images into a Twoliter project's build directory and use Twoliter to
    publish those variant images.

    In these cases, Kit dependencies are not necessary, and it can be useful
    to avoid resolving them and comparing them against Twoliter.lock.

    This change allows skipping Kit lockfile verification only when
    executing certain `twoliter make` targets.

Testing done:

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

cbgbt commented 2 months ago

Sorry for the churn. I have another TL interface change I'd like to make. I can save it for a subsequent PR, though.

cbgbt commented 2 months ago

I disabled some additional, unnecessary artifact fetching. Some make targets needlessly requested workspace sources as an artifact of previously being part of the monorepo.

I need to test that specific change a bit more before merging, though.

cbgbt commented 2 months ago

Commenting so that GitHub will provide a useful comparison view.

cbgbt commented 2 months ago

^ addresses feedback from @bcressey

sumukhballal commented 2 months ago

LGTM! 👍

cbgbt commented 2 months ago

Force push to remove erroneous println!

cbgbt commented 2 months ago

build and default are effectively aliases to build-variant and are used in the bottlerocket repo. These targets now require kit verification.

cbgbt commented 2 months ago

^ rebase (without changes) on to develop

cbgbt commented 2 months ago

^ make changes to work with #357

cbgbt commented 2 months ago

^ force push because I missed build-all 😅