bottlerocket-os / twoliter

A build tool for customizing Bottlerocket
Other
24 stars 25 forks source link

twoliter: drop PATH override for debuginfo #383

Closed bcressey closed 1 month ago

bcressey commented 1 month ago

Issue number: Related: https://github.com/bottlerocket-os/bottlerocket-sdk/pull/210

Description of changes: find-debuginfo overrides $PATH to prefer its own directory, so this wasn't working as expected.

Drop this workaround to avoid conflating host and target tools, which can mask build logic errors in package specs.

Testing done: Built the core kit on both host architectures, for both target architectures, after taking the SDK change. No objcopy failures were logged.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.