bottlesdevs / Bottles

Run Windows software and games on Linux
https://usebottles.com
GNU General Public License v3.0
6.2k stars 258 forks source link

[Bug]: DLL overrides do not save #1637

Closed xioren closed 2 years ago

xioren commented 2 years ago

Describe the bug

You can create a dll override, and it defaults to Builtin (Wine) but if you you change to any other option, for example Native, then Builtin it is not remembered. Every time the dll override options menu is opened it is back on Builtin (Wine).

To Reproduce

go to dll overrides change default method to anything else

Package

Flatpak from Flathub

Distribution

debian testing

Health Check

Version: 2022.6.14-brescia
Display:
    X.org: true
    X.org (port): :99.0
    Wayland: false
Graphics:
    vendors:
        nvidia:
            vendor: nvidia
            envs:
                __NV_PRIME_RENDER_OFFLOAD: '1'
                __GLX_VENDOR_LIBRARY_NAME: nvidia
                __VK_LAYER_NV_optimus: NVIDIA_only
            icd: /usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/nvidia_icd.json:/usr/lib/i386-linux-gnu/GL/vulkan/icd.d/nvidia_icd.json
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 5.18.0-1-amd64
Distro:
    Name: GNOME
    Version: '"42 (Flatpak runtime)"'
Disk:
    Total: 8367566848
    Free: 8367411200
RAM:
    MemTotal: 15.6GiB
    MemAvailable: 13.0GiB
Tools:
    cabextract: true
    p7zip: true
    patool: true
    glibc_min: '2.33'
Bottles_envs: null

Display Protocol

X11

Display Backend used by Bottles

I don't know

Additional context

No response

mirkobrombin commented 2 years ago

I think it’s a visual bug. Are dll stored correctly in bottle.yml?

xioren commented 2 years ago

I don't know. here is my bottle.yml

Arch: win64
Creation_Date: '2022-06-15 13:23:57.911477'
Custom_Path: false
DLL_Overrides:
    concrt140: n,b
DXVK: dxvk-1.10.1
Environment: Application
Environment_Variables: {}
External_Programs: {}
Installed_Dependencies:
- arial32
- times32
- courie32
- vcredist2019
LatencyFleX: latencyflex-v0.1.0
Latest_Executables: []
NVAPI: dxvk-nvapi-v0.5.4
Name: Topaz
Parameters:
    custom_dpi: 96
    discrete_gpu: true
    dxvk: true
    dxvk_hud: false
    dxvk_nvapi: false
    fixme_logs: false
    fsr: false
    fsr_level: 5
    fullscreen_capture: false
    gamemode: false
    gamescope: false
    gamescope_borderless: false
    gamescope_fps: 0
    gamescope_fps_no_focus: 0
    gamescope_fullscreen: true
    gamescope_game_height: 0
    gamescope_game_width: 0
    gamescope_scaling: false
    gamescope_window_height: 0
    gamescope_window_width: 0
    latencyflex: false
    mangohud: false
    mouse_warp: true
    obsvkc: false
    pulseaudio_latency: false
    renderer: gl
    sync: wine
    take_focus: false
    use_runtime: false
    use_steam_runtime: false
    virtual_desktop: false
    virtual_desktop_res: 1280x720
    vkbasalt: false
    vkd3d: true
Path: Topaz
Runner: caffe-7.10
State: 0
Uninstallers:
    arial32: false
    courie32: false
    times32: false
    vcredist2019: true
Update_Date: '2022-06-15 13:32:58.304959'
VKD3D: vkd3d-proton-2.6
Versioning: false
Windows: win10
WorkingDir: ''

I am trying to override concrt140 to native, then built in.

xioren commented 2 years ago

I will say that I manually added it to user.reg after having issues doing it in app. So I dont know if that manual entry is reflected in the bottle.yml.

[Software\\Wine\\DllOverrides] 1652108307
#time=1d863b53d245b82
"concrt140"="native,builtin"
mirkobrombin commented 2 years ago

concrt140: n,b

Your override is set to native,builtin so it got saved, then it’s a visual bug

I will say that I manually added it to user.reg after having issues doing it in app. So I dont know if that manual entry is reflected in the bottle.yml.

[Software\\Wine\\DllOverrides] 1652108307
#time=1d863b53d245b82
"concrt140"="native,builtin"

No it’s not reflected as bottles uses environment variables for dll overrides when editing from preferences

xioren commented 2 years ago

Okay thanks, well up to you if you want to keep this open.

mirkobrombin commented 2 years ago

I’ll keep open as it’s a bug 😂