bottlesdevs / Bottles

Run Windows software and games on Linux
https://usebottles.com
GNU General Public License v3.0
6.34k stars 265 forks source link

[Bug]: Unable to create bottle on fresh install #2621

Closed TheEvilSkeleton closed 1 year ago

TheEvilSkeleton commented 1 year ago

Describe the bug

On a freshly installed Bottles (without any prior configuration), I am unable to create a new bottle, no matter the environment.

After creating the bottle for the first time in the stable branch, I can create bottles afterwards.

To Reproduce

  1. Get rid ~/.var/app/com.usebottles.bottles, if it exists
  2. Install Bottles flatpak from the latest commit
  3. Launch, set it up and create a bottle

Package

Flatpak from GitHub Artifacts

Distribution

Fedora 37 Silverblue

Debugging Information

Official Package: true
Version: 50.2-ef71b34
DE/WM: gnome
Display:
    X.org: true
    X.org (port): :0
    Wayland: true
Graphics:
    vendors:
        amd:
            vendor: amd
            envs:
                DRI_PRIME: '1'
            icd: /usr/lib/x86_64-linux-gnu/GL/vulkan/icd.d/radeon_icd.x86_64.json:/usr/lib/i386-linux-gnu/GL/vulkan/icd.d/radeon_icd.i686.json
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 6.1.7-200.fc37.x86_64
Disk:
    Total: 4134936576
    Free: 4134776832
RAM:
    MemTotal: 7.7GiB
    MemAvailable: 3.8GiB
Bottles_envs: null

Troubleshooting Logs

22:31:22 (ERROR) Error while running async job: <bound method Manager.create_bottle of <bottles.backend.managers.manager.Manager object at 0x7fd99fad1840>>
    Exception: a bytes-like object is required, not 'str'

  File "/app/share/bottles/bottles/frontend/utils/threading.py", line 61, in __target
    result = self.task_func(*args, **kwargs)
  File "/app/share/bottles/bottles/backend/managers/manager.py", line 1239, in create_bottle
    rk.apply_cmd_settings()
  File "/app/share/bottles/bottles/backend/wine/regkeys.py", line 222, in apply_cmd_settings
    self.reg.import_bundle({
  File "/app/share/bottles/bottles/backend/wine/reg.py", line 125, in import_bundle
    logging.info(res, )
  File "/app/share/bottles/bottles/backend/logger.py", line 69, in info
    self.root.info(self.__color("info", message), )
  File "/app/share/bottles/bottles/backend/logger.py", line 48, in __color
    if message is not None and "\n" in message:

Additional context

First regression appeared on https://github.com/bottlesdevs/Bottles/pull/2505#issuecomment-1404523023.

I can reproduce it in a fresh Fedora 37 Kinoite install (VM).

Kinsteen commented 1 year ago

This has been fixed since cde89f07e0281b5277ad2879e2ea1f5afcb3828c