search

bottom-software-foundation / spec

A spec for the bottom encoding format.
MIT License
100 stars 1 forks source link

Rename byte separator -> byte terminator #8

Closed Moire9 closed 1 year ago

Moire9 commented 2 years ago

It makes more sense to call it a terminator, since it terminates groups of encoded bytes, rather than separating them. If it actually were a seperator, a trailing one would not be required, like line endings on DOS.

redgoldlace commented 1 year ago

Hi, thanks for the PR. Sorry that I was so slow to get back to you!

This looks good to me overall and I don't have any issues with the changes. There is a tiny piece of trailing whitespace in one of the table rows, but that's a nit more than anything and doesn't matter too much.

Thanks again!

Moire9 commented 1 year ago

Thanks!