bougarfaoui / ui-carousel

🎨 Angular carousel Component 🔥
https://bougarfaoui.github.io/ui-carousel/
MIT License
79 stars 53 forks source link

Fixes ObjectUnsubscribedError on prevSubject and nextSubject unsubscr… #3

Closed msamprz closed 6 years ago

msamprz commented 6 years ago

Fixes ObjectUnsubscribedError on prevSubject and nextSubject unsubscribing

This issue arose on:

Angular CLI: 1.6.1
Node: 8.5.0
OS: win32 x64
Angular: 5.2.4
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cdk: 5.2.0
@angular/cli: 1.6.1
@angular/material: 5.2.0
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.1
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.6.2
webpack: 3.10.0
bougarfaoui commented 6 years ago

@msamprz Thanks for the PR :)

msamprz commented 6 years ago

@bougarfaoui Thanks for the module, my dude :)

sagarguhe commented 6 years ago

I am not getting this change in my install.. what to do?

msamprz commented 6 years ago

@sagarguhe I believe @bougarfaoui hasn't pushed this code to npm. I found this out later in another issue in this repo. The solution is to use a different package, from a fork of this fix. I would have done it myself but I thought @bougarfaoui would push it to npm. Below you can find the package.

https://www.npmjs.com/package/ng-carousel-iuno https://github.com/goergch/ui-carousel

npm i ng-carousel-iuno

sagarguhe commented 6 years ago

@msamprz thanks for the solution! I have installed your forked package using npm i ng-carousel-iuno --save it is installed correctly but when I try to import UICarouselModule from ng-carousel-iuno ng-serve throws this error: ERROR in src/app/components/service-view/service-view.module.ts(7,34): error TS2307: Cannot find module 'ng-carousel- iuno'

sagarguhe commented 6 years ago

@msamprz never mind I installed the package again and it fixed the issue.. :) thanks for the fix :100:

msamprz commented 6 years ago

@sagarguhe no problem. Good luck!

Muthukumaruma commented 6 years ago

I updated the package but still I am facing the same issue

msamprz commented 6 years ago

Is your package the fork?

Muthukumaruma commented 6 years ago

hope no, I installed through npm

msamprz commented 6 years ago

From what I know and remember, this PR merge was not pushed to npm, so the fix is not implemented into the npm package. Try npm i ng-carousel-iuno this package.