search

boulder-food-rescue / food-rescue-robot

A Rails App for Managing "Just in Time" Food Rescue, Developed by/for Boulder Food Rescue in Boulder, CO, USA
49 stars 56 forks source link

Upgrade Ruby from 2.2.6 to 2.3.7 #160

Closed Aupajo closed 6 years ago

Aupajo commented 6 years ago

Ruby 2.2 is on its last legs:

We are planning to end the support of the Ruby 2.2 series at the end of March 2018.

Prior to this PR, we were running 2.2.6, which four versions behind the latest patch release for the 2.2 series, 2.2.10. These patch releases include numerous bug fixes and security updates.

Ideally, we'd move all the way to the latest release (2.5.1), but some further changes are going to be necessary to support that. (dependency upgrades). For now, Ruby 2.3.7 is as high as I can take it while leaving the current Gemfile depdencies as they are.

rylanb commented 6 years ago

@Aupajo Could you update the .travis.yml to fix the tests running: Your Ruby version is 2.2.6, but your Gemfile specified 2.3.7?

Thanks!

Aupajo commented 6 years ago

@rylanb I was trying to figure that out. Turned out .travis.yml wasn't in this branch when I forked it – have rebased and updated it.

Tests are now passing on CI, but Rubocop is failing.

rylanb commented 6 years ago

I think the merge conflicts are from your other branches updates that I just merged. Sorry if I did those in the wrong order, there!

Aupajo commented 6 years ago

@rylanb No worries. All sorted!

rylanb commented 6 years ago

Thanks @Aupajo !! Great work. Excited to be up to Ruby 3!