search

boun-tabi-LMG / turkish-lm-tuner

Turkish LM Tuner
https://boun-tabi-lmg.github.io/turkish-lm-tuner/
MIT License
73 stars 6 forks source link

Fix EvalPrediction case in compute_metrics #49

Closed gokceuludogan closed 5 months ago

gokceuludogan commented 5 months ago

This pull request fixes the case when compute_metrics gets an EvalPrediction parameter rather than a tuple.

A condition is added to handle such case.

The new version is tested on summarization.

furkanakkurt1335 commented 5 months ago

EvalPrediction can have inputs as well.

I had added something for this in my branch for QA. Can you check it? It should now be merged anyway.

gokceuludogan commented 5 months ago

Fixed and tested! It seems to be working fine. For future reference, I believe it would be beneficial to have a separate PR for this.

furkanakkurt1335 commented 5 months ago

Fixed and tested! It seems to be working fine. For future reference, I believe it would be beneficial to have a separate PR for this.

I don't have a PR 😅