search

bouncepaw / mycorrhiza

🍄📑 Filesystem and git-based wiki engine for the independent web written in Go and using Mycomarkup as its primary markup language.
https://mycorrhiza.wiki
GNU Affero General Public License v3.0
300 stars 26 forks source link

`silentGitsh` ignores environment variables #209

Closed shivrm closed 9 months ago

shivrm commented 9 months ago

silentGitsh passes only gitEnv when calling commands, whereas normal gitsh passes both system environment variables and gitEnv. The comments say that "silentGitsh is like gitsh, except it writes less to the stdout.", so I'm not sure if this is intentional behaviour.

I was running Mycorrhiza on an old device and it was crashing whenever I opened the 'Recent Changes' page. Changing this one line fixed the problem.

bouncepaw commented 9 months ago

Well, I intended them to be the same, except for the output. Thanks for reporting, I'll look into that.