search

boundary / folsom

Expose Erlang Events and Metrics
Apache License 2.0
586 stars 166 forks source link

Fix a race against querying the ETS/DETS tables. #59

Closed jlouis closed 10 years ago

jlouis commented 11 years ago

There is a window from the query of, say, ets:all() to the point where we fetch out the table data. The table may disappear in between. This patch fixes this problem by ignoring such tables and returning the empty list for those where there is no data available anymore.

Please read through this patch carefully. I think it works, but it has not seen much testing apart from the bare necessities. That is, it doesn't change the common path.

joewilliams commented 11 years ago

Please add tests for the "bare necessities" and I will merge. Thanks!

jlouis commented 11 years ago

I'll get on this one later today, hopefully.

joewilliams commented 10 years ago

Have you had a chance to add the tests? I would like to merge this one.

joewilliams commented 10 years ago

@jlouis Think you'll have time to add tests for this one?