search

boundary / folsom

Expose Erlang Events and Metrics
Apache License 2.0
586 stars 166 forks source link

EWMA vs mean unit of measure inconsistency in meters #74

Open vladaionescu opened 10 years ago

vladaionescu commented 10 years ago

Meters can be used for a number of things, but consider this example: We want to measure the number of events per second, where an event is folsom_metrics:notify(Name, 1).

So we do folsom_metrics:get_metric_value(Name). What we get in response is

[{count,...}, {one, ...}, {five, ...}, {fifteen, ...}, {day, ...}, {mean, ...}, {acceleration, ...}]

where one, five, fifteen and day are measured in events per second, but mean is measured in events per _micro_ second. Furthermore, acceleration is measured in events per second squared.

I believe it would be more consistent if mean were measured in events per second as well.

Suggested fix: divide this value by 1000000. May need to do something similar for meter reader as well.

joewilliams commented 10 years ago

I would entertain a PR for this, please submit one with tests and I'll review.

joewilliams commented 8 years ago

Folsom has moved, please resubmit your issue at https://github.com/folsom-project Thanks!