boundary / folsom

Expose Erlang Events and Metrics
Apache License 2.0
586 stars 166 forks source link

Make compatible with R17 #79

Closed cybergrind closed 10 years ago

cybergrind commented 10 years ago

Fix compilation error:

Compiling ...deps/meck/src/meck_proc.erl failed:
...deps/meck/src/meck_proc.erl:51: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                          
...deps/meck/src/meck_proc.erl:408: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:445: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:446: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:476: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:477: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:482: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:483: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:488: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
...deps/meck/src/meck_proc.erl:489: type dict/0 is deprecated and will be removed in OTP 18.0; use use dict:dict/0 or preferably dict:dict/2                                                                         
ERROR: compile failed while processing ...deps/meck: rebar_abort
joewilliams commented 10 years ago

Does this also work on previous Erlang versions?

cybergrind commented 10 years ago

This is related only tests so it only fix compilation error under R17

Regarding tests I have same errors with R17/R16 with patch and without too:

folsom_erlang_checks: create_delete_metrics (create and delete tests)...*failed*
in function ets:member/2
  called as member(folsom,counter)
in call from folsom_ets:handler_exists/1 (src/folsom_ets.erl, line 96)
in call from folsom_ets:add_handler/2 (src/folsom_ets.erl, line 64)
in call from folsom_erlang_checks:'-create_delete_metrics/0-fun-0-'/0 (test/folsom_erlang_checks.erl, line 496)
in call from folsom_erlang_checks:create_delete_metrics/0 (test/folsom_erlang_checks.erl, line 496)
**error:badarg