search

boundary / folsom

Expose Erlang Events and Metrics
Apache License 2.0
586 stars 166 forks source link

Work around a race condition when deleting slide counters #99

Closed solvip closed 8 years ago

solvip commented 8 years ago

If SampleMod:trim/2 gets called by a folsom_sample_slide_server after the ETS table the server is trimming has gone away, it will go into a restart loop and eventually bring down the folsom_sample_slide_sup supervisor. This fixes that by catching badarg and stopping the erronous process normally.

joewilliams commented 8 years ago

Thanks @solvip, this looks like a good patch. Unfortunately I, as maintainer of folsom, no longer have write access to the repo. Sorry, I am not sure when or if this PR will be merged.

solvip commented 8 years ago

Thanks @joewilliams, too bad. Hopefully someone else will pick this up.

joewilliams commented 8 years ago

Maybe @GabrielNicolasAvellaneda @dominicphillips or @sigil66 can give me access again to folsom, bear, folsom_webmachine and folsom_cowboy.

GabrielNicolasAvellaneda commented 8 years ago

Hey @joewilliams I don't have access too, but maybe @sigil66 or @codemoran can help.

dominicphillips commented 8 years ago

@joewilliams Sorry, I can't either.

puzza007 commented 8 years ago

Is there any appetite to fork and create a separate organisation to maintain these? I'd be happy to help out.

solvip commented 8 years ago

I would be happy to help as well

joewilliams commented 8 years ago

@puzza007 @solvip okay, I have started https://github.com/folsom-project with fresh copies of the folsom related repos (so we aren't tied in anyway). Please let anyone you know that the repo is changing.

@solvip can you please resubmit your PR over there?

puzza007 commented 8 years ago

@joewilliams :+1:

solvip commented 8 years ago

:+1: https://github.com/folsom-project/folsom/pull/1