search

bounswe / 2021SpringGroup4

This is the project repository of Group 4 for Boğaziçi University's Fundamentals of Software Engineering course.
2 stars 1 forks source link

Backend: Fix events update endpoint bug #239

Closed kerimoglutolga closed 2 years ago

kerimoglutolga commented 2 years ago

Describe the bug When a patch request is sent to /api/events// to update the information of an event, the server responds positively while the update does not actually take place.

To Reproduce Steps to reproduce the behavior:

  1. Use the login endpoint to obtain an authentication token.
  2. Create an event using the relevant endpoint, obtain the event id.
  3. Send a patch request changing any field of that event to /api/events// along with the authorization token.
  4. Use relevant endpoint to retrieve event information and check if the event has updated, it has not.

Expected behavior Event should update successfully by an authorized request.

Desktop (please complete the following information):

kerimoglutolga commented 2 years ago

The bug is now fixed and the fix is deployed. PR: https://github.com/bounswe/2021SpringGroup4/pull/213

The bug was caused by an oversight in the backend where we have customized the patch method for handling adding/removing applicants/participants to events since they need to be handled differently than the regular patch procedure.