search

bounswe / 2021SpringGroup4

This is the project repository of Group 4 for Boğaziçi University's Fundamentals of Software Engineering course.
2 stars 1 forks source link

Practice-app: Formula 1 API #67

Closed eceasslan closed 3 years ago

eceasslan commented 3 years ago

Created Formula 1 API and its corresponding HTML files. Wondering if everything is fine with my API, so waiting for your reviews.

yigitsarioglu commented 3 years ago

I checked your code, I don't see anything wrong with your code.. You should also create unittest for your api. Also you may add your api name and its url to apiOverview method in views.py.

ihsanmertatalay commented 3 years ago

I looked your code it will work correctly.

eceasslan commented 3 years ago

I checked your code, I don't see anything wrong with your code.. You should also create unittest for your api. Also you may add your api name and its url to apiOverview method in views.py.

I created unit tests and added my API name and its url to apiOverview method.

kerimoglutolga commented 3 years ago

I have fixed the conflict in urls.py and merging this.

berkaygumus commented 3 years ago

Your API works properly. Maybe it could be better if we search for drivers with Latin alphabet, too. I mean when I write Raikkonen rather than Räikkönen, it says "there is no driver". But I think it is not a big issue. Your API is enjoyable and cool for me as an F1 follower.