search

bounswe / bounswe2015group3

Boun Software Engineering Couse Project /Spring 2015 /Group#3
4 stars 0 forks source link

Review code #239

Closed BurakYilmaz92 closed 8 years ago

BurakYilmaz92 commented 8 years ago

my commit: https://github.com/bounswe/bounswe2015group3/commit/54dc9736d07d45d0858192b3e1b6744218a5c08b

Could you please review the commit I mentioned? In this commit, I created function of creating group action and showing all groups in mobile platform

tuba-topaloglu commented 8 years ago

First of all, nicely written code, thanks for contribution. However some points that could be improved are: * There are some unused variables in NewGroupActivity such as startDateEditText etc. * Similarly Group class has some unused variables. Except for the above mentioned matters, the code is bug-free and easy to understand. The names of the variables make sense. There are no comments in the code, but I don't think this is a problem in this case, as the variable and method names are chosen well and the coding style is easy to follow and read through. As a side note, the built-in code inspector suggests that LinearLayout in a ScrollView should have "wrap_content" as its height.