code review req - Githubissues

bounswe / bounswe2015group7

Sculture, The Software Project of Future

6 stars 4 forks source link

code review req #175

Closed bilalyasar closed 8 years ago

bilalyasar commented 8 years ago

@fthdgn please review my commit https://github.com/bounswe/bounswe2015group7/commit/c66ce19be3d40d9e9e6a919fe2d737e3aa50f1df

empaksoy commented 8 years ago

please create a pull request and assign to me

fthdgn commented 8 years ago

This commit is already on master. You should review it on this issue.

safaorhan commented 8 years ago

I will review it.

bilalyasar commented 8 years ago

@safaorhan please write comments here

safaorhan commented 8 years ago

I commented on the commit https://github.com/bounswe/bounswe2015group7/commit/c66ce19be3d40d9e9e6a919fe2d737e3aa50f1df also.

Here is a copy in case someone may omit:

Please use camelCase in the both class fields and the function parameters.
Please add unit tests.
Wrong exception on the line: https://github.com/bounswe/bounswe2015group7/commit/c66ce19be3d40d9e9e6a919fe2d737e3aa50f1df#diff-53daf4ba68e3ce9100fbbfaca8d01cd8R171
Setters are not necessary in TagResponse.java.
Please add javadoc to this function since that it is a public function in the line: https://github.com/bounswe/bounswe2015group7/commit/c66ce19be3d40d9e9e6a919fe2d737e3aa50f1df#diff-53daf4ba68e3ce9100fbbfaca8d01cd8R164