bounswe / bounswe2016group8

CmpE 352/451 Group Project
Apache License 2.0
1 stars 1 forks source link

Assignment 5 - Peer Review for Group 11 #24

Open ozankep opened 8 years ago

ozankep commented 8 years ago

Use Case Diagram

I think the difference between guest user and the registered user is a bit blurry. As I understood from use case diagram; guest users can report users. This may be a bit dangerous cause it is open to threats from bots. Reporting feature should require registration. Also allowing guest users to follow topics will create abuse problems. Besides, when there is no user information, content will not be pushed to that user. Apart from these, the diagram is very clean, easy to understand. Use case scenarios are pretty detailed. We did it different, I am not sure which one is true, but there is no harm making it a bit simpler, i think.

Sequence Diagram

I liked its simplicity, diagrams can easily explain the process. Functions names may be added on arrows. Other features may be added , follow topic, report topics, login .. etc.

Activity Diagram

Diagram3: while introducing topic, adding glossary, reference or test should be added. Diagram 4: search by tags feature may be added. Also an arrow has no data, i didnt understand why it stands like this. Diagram5: adding relations between topics is a good feature and well explained. The other diagrams do their duties to me.

Class Diagram

There are some missing variables and functions, • Registered user should have list variable for rated topics; topics that user rated. There is a vlist variable named highestratedPosts but it means another thing. • There is a list for followed users, but there is not for followers list. There should be. • Posts, and users can be rated, but there is no variable to save ratings. • Posts and Topics have no id, it may be needed for easy database navigation.