Add Comment Functionality

bounswe / bounswe2017group5

Interestr - Build your own interest-based community

MIT License

6 stars 3 forks source link

Add Comment Functionality #137

Closed Morgazipa closed 6 years ago

Morgazipa commented 6 years ago

About

Related Issues: #133

Implemented comments with its views in the API and disallowed change of members of a group through API views.

Changes

Created comment class
Implemented its relations with user and post objects
Changed moderators and members fields to read only in the group serializer

Visuals

Group created with empty members:

group list

karacasoft commented 6 years ago

@Morgazipa Really good. All the functionality described here works. I'm afraid, I'll have to request the tests for the comment functionality, too. I know that we have accepted some pull requests that did not include tests. But we have to start doing this at some point. Since we don't have to rush for the comments functionality, We may just wait for the tests to be written.

Morgazipa commented 6 years ago

I added some tests. Since we have not yet implemented any permission related stuff, I did not consider whether the owner of the post is a member of the group or not.

Morgazipa commented 6 years ago

I tried to merge the changes locally since there were some conflicts with @norubai 's commits . I hope I did not break anything :)