bounswe / bounswe2017group5

Interestr - Build your own interest-based community

MIT License

6 stars 3 forks source link

Rewrite the test cases for groups #138

Closed oal55 closed 6 years ago

oal55 commented 6 years ago

About

Related Issues: #96, #133

Changes

Rewritten the group tests. #96
We now have a class based group-operation view. #96
group-operation route now has a name field. #96
We can now create a group with empty members & moderators fields. #133
Changed moderators and members fields to read only in the group serializer (I saw the other guy said he did this in #137 too, but I couldn't see where he changed it. So I modified the serializer as well :$ ). #133

Closes #133

karacasoft commented 6 years ago

This has files that are also changed on @Morgazipa 's commits in #137. Prepare for conflicts... 😄

smddzcy commented 6 years ago

nit: There is a field for related issues in the issue template, please use there for consistency. Issue title is not a good place for this 😄

smddzcy commented 6 years ago

Also, again it's not that important but using simple present tense for issue titles is a good practice

oal55 commented 6 years ago

Thanks for the feedbacks

Morgazipa commented 6 years ago

My bad, I should have created an issue for failing tests. Anyway, since our changes are almost identical (except that he introduced different passwords for users) I can revert my changes. But I think that we should change the memberOperation to work with group names ( right now group name is not even an unique field). @triforce930 has raised some other concerns in https://github.com/bounswe/bounswe2017group5/commit/2287f1e4812db4c6fdc31c1bb3f5866bca66938d#diff-a224ae36892ad9b8a65a454b5c43cbf0.

smddzcy commented 6 years ago

I adjusted the description (added a Closes #?? line) to auto-close the group empty members bug issue, AFAICS this PR fixes that bug. Merge whenever you are ready.

oal55 commented 6 years ago

Done ~~~