bounswe / bounswe2017group5

Interestr - Build your own interest-based community
MIT License
6 stars 3 forks source link

Fix "Improvement/api reduce data" #172

Closed Morgazipa closed 6 years ago

Morgazipa commented 6 years ago

About

In the pull request referenced above, the data template serializer is changed to include basic user and group info. However, since the same endpoint was used for template creation using only id's of group and user, the template creation was broken. This PR is meant to fix this issue.

Changes

smddzcy commented 6 years ago

I'll let @triforce930 review this one since he's the owner of the fixed PR 👌

karacasoft commented 6 years ago

At some parts, the changes I want were reverted. I won't accept this but will fix the error by myself since it's my mistake at the first place. The live version will be bugged for now. We can revert master to its previous version if it's urgently required by any of the team members.

karacasoft commented 6 years ago

I'll suggest leaving this around though, if I change my mind and want to revert back my changes anyway

karacasoft commented 6 years ago

I think I'll accept these changes and create a new module for serializers I want

Morgazipa commented 6 years ago

Oops. I seem to have reverted unknowingly some other changes while playing with Git. I did reset that commit and hope everything works fine know.