bounswe / bounswe2017group5

Interestr - Build your own interest-based community
MIT License
6 stars 3 forks source link

Select (dropdown) support on the web frontend #174

Closed ThoAppelsin closed 6 years ago

ThoAppelsin commented 6 years ago

About

To give our users an interface to select one out of many options kind of input, we needed either a group of radio buttons, or a dropdown. I have made the necessary changes to support the select (dropdown) fields on the web frontend.

Its options (items) can be edited similar to the way that the labels are editable. This time, with an auto-resizing (in height and width) textarea.

Note: The branch is out-of-date. The changes made, however, should be isolated. Tell me to merge the master into it, if necessary.

Changes

Visuals

dropdowns

Note 1: The animation fails to depict the horizontal auto-resizing of the editing area.
Note 2: The branch is out-of-date with respect to the master branch, which got two more recent merges, and so is the animation.

Testing

How can this contribution be tested? Use the following structure:

Morgazipa commented 6 years ago

Unfortunately, due to changes made to serializers in PR #171, creation of posts/comments does not work. Although I tried to fix the problems introduced in #172, I only changed data template serializer because I thought that the tests for comments and posts would pass if we would re-write them using "data" field instead of "text" in post creation.

smddzcy commented 6 years ago

@Morgazipa @triforce930 What is the final status; do posting/commenting work now, and can we merge this PR?

Morgazipa commented 6 years ago

@smddzcy Unfortunately, not yet.

smddzcy commented 6 years ago

@triforce930 We have 2 options here:

  1. Reverting #171
  2. Fixing #171

Which one do you choose 😄

karacasoft commented 6 years ago

I'll fix it today :+1:. Sorry for the inconvenience

smddzcy commented 6 years ago

Since everything is fixed, we can merge it now.